Integrate STAC Catalog and Bbox field on Databrowser #72
Conversation
|
To play around with on production, it's running on dev machine and working for all datasets. |
| <InputGroup.Text>North</InputGroup.Text> | ||
| <Form.Control | ||
| value={maxLat} | ||
| placeholder="e.g. 10" |
There was a problem hiding this comment.
in case of the bounding box, I think it would make more sense to write the min and max values into the placeholder
| }; | ||
|
|
||
| const isValidLatitude = (value) => { | ||
| const num = parseFloat(value); |
There was a problem hiding this comment.
parseFloat will parse strings like 12blabla to 12. Hence, both isValid..-Function will return true for this kind of string. If you then try to apply this search parameter, the website will crash.
| <div className="d-flex gap-3 mb-2"> | ||
| <div className="flex-grow-1"> | ||
| <InputGroup> | ||
| <InputGroup.Text>West</InputGroup.Text> |
There was a problem hiding this comment.
As Martin already said, I think it would be better to talk about longitudes and latitudes. I am also confused that it says West, East, etc. but the error messages are mentioning min longitude etc.
| maxLat && | ||
| parseFloat(minLat) > parseFloat(maxLat) | ||
| ) { | ||
| errorMessage = "Max latitude must be greater than min latitude"; |
There was a problem hiding this comment.
I would like it if error messages like this would also appear in the minLatError or the maxLatError (one is enough I guess) and not only in the tooltip.
| </div> | ||
| </div> | ||
|
|
||
| <div className="d-flex gap-3 mb-3"> |
There was a problem hiding this comment.
The flex-box is changing sizes when an error message appears below. I think I would prefer something grid-based instead
|
Thanks for the review!
|
|
it's done from my side, could you please review this again, thanks! |
This PR adds support for accessing both dynamic and static STAC (SpatioTemporal Asset Catalog) based on user search parameters. It also improves the data browser by introducing a bounding box field for selecting and validating coordinates.
BBoxSelector: Make users able to search based on the bounding box coordinates.CatalogExportDropdown: Provides options for exporting catalogs, including STAC dynamic and static catalogs.